On Sun, 12 May 2024 18:52:30 GMT, Alan Bateman <al...@openjdk.org> wrote:
> This mostly looks good. I'm just puzzled CHECK_EXCEPTION_NULL_FAIL. The JNI > functions GetStaticMethodID, GetMethodID and NewObject return NULL with a > pending exception when they fail. So I would expect CHECK_EXCEPTION_NULL_FAIL > to just check if obj is NULL rather check for an exception first. It's not > wrong to check for an exception, just curious when looking at this macro. Hi @AlanBateman, thanks for taking a look. That's a good point - would it be worthwhile to delete the exception check in this case? ------------- PR Comment: https://git.openjdk.org/jdk/pull/18786#issuecomment-2108464274
