On Tue, 21 May 2024 21:16:52 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 78:
>>
>>> 76: String line = null;
>>> 77: synchronized (writeLock) {
>>> 78: synchronized(readLock) {
>>
>> Suggestion:
>>
>> synchronized (readLock) {
>
> Sorry, but no. It would be inconsistent with the rest of the file, which for
> whatever reason (copy-paste?) does not use whitespace between `synchronized`
> and `(readLock)`.
It looks strange to have space in one case, and don't have it in another. I
would'nt call it consistent.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1609287823
