On Wed, 12 Jun 2024 17:31:09 GMT, Rob Spoor <d...@openjdk.org> wrote:
>> Viktor Klang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 32 commits: >> >> - Lowering upper boundary of gatherer composition testing to 512 >> - Javadoc clarifications for Gatherer type parameters, >> correcting descriptions of Integrator type parameters, >> and more consistently use "initializer function" instead >> of "supplier function". >> - Addressing trailing whitespace complaint >> - Adding @implSpec for Gatherer.andThen, plus adds tests to verify the >> default impls for Gatherer-related interfaces >> - Clarifying that Stream#gather is a stateful intermediate operation >> - Improvements after feedback >> - Unpacking the rethrown exceptions from Gatherers.mapConcurrent() >> - Addressing last review feedback >> - Apply suggestions from code review >> >> Integrates Paul Sandoz's feedback/changes >> >> Co-authored-by: Paul Sandoz <paul.d.san...@googlemail.com> >> - Minor improvements to Gatherer Javadoc >> - ... and 22 more: https://git.openjdk.org/jdk/compare/69413690...49c94c7f > > src/java.base/share/classes/java/util/stream/Gatherer.java line 296: > >> 294: * @implSpec This method always returns the same instance. >> 295: * >> 296: * @see Gatherer#finisher() > > Today I noticed that this is the wrong link. It should be > `Gatherer#combiner()`, not `Gatherer#finisher()`. @robtimus Thanks! I'll address that 👍 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1637068982
