On Tue, 18 Jun 2024 20:39:30 GMT, Justin Lu <[email protected]> wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333396: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 561:
>
>> 559: toAppendTo.append(choiceFormats[i]);
>> 560: } catch (IOException ioe) {
>> 561: throw new UncheckedIOException(ioe.getMessage(), ioe);
>
> Perhaps `AssertionError` instead of `UncheckedIOException` is better suited
> here and in the other ocurrences.
This can be removed if using `StringBuf`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1645304136
