On Mon, 1 Jul 2024 13:16:39 GMT, David M. Lloyd <d...@openjdk.org> wrote:
> According to https://wiki.openjdk.org/display/csr/CSR+FAQs, only changes to > public and exported APIs in the `jdk.*`, `java.*`, and `javax.*` packages > need a CSR. This PR changes public and exported APIs in the `sun.misc` > package, and changes public but non-exported APIs in the > `jdk.internal.reflect` package, so I don't think it qualifies, does it? CSR is required for changes to any public and exported API, including in `sun.misc` package, and including trivial signature changes (such as making a method default in an interface, or marking a utility class final). The presence of a CSR doesn't necessary mean a patch will be harder to integrate; it's often for archival and quality-ensurance purposes. Here's an example CSR for changes to APIs in `sun.misc`: https://bugs.openjdk.org/browse/JDK-8331686 (#19174) ------------- PR Comment: https://git.openjdk.org/jdk/pull/19702#issuecomment-2200140427
