On Tue, 16 Jul 2024 23:50:17 GMT, Chen Liang <li...@openjdk.org> wrote:
> `WritableElement` has always been one of the biggest peculiarities of > ClassFile API: it exposes element writing yet has no corresponding reading > ability exposed. Its existence creates a lot of API noise, increasing > maintenance cost in the long run. (This is an iceberg whose tip was exposed > in #14705) > > Removal details: > - `LocalVariable/LocalVariableType.writeTo` > - `WritableElement` > - In `BufWriter`: > - `writeList(List<WritableElement>)` > - `writeListIndices`: Hidden as we are not exposing > `BoundAttribute.readEntryList` > - `writeBytes(BufWriter other)` > - `ClassReader.compare`: Avoid reading from `BufWriter` > > Future implementation cleanup out of scope of this patch: > - Annotation writing can be upgraded and move away from `Util.Writable` > - The writing of CP indices and attributes can move to their dedicated methods > - reading of entry list can pair up with writing of entry list in > ClassReader/BufWriter in future addition Great job! ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20205#pullrequestreview-2182288974
