On Fri, 19 Jul 2024 20:46:37 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333396: Use StringBuilder internally for java.text.Format.* formatting
>
> src/java.base/share/classes/java/text/CompactNumberFormat.java line 583:
>
>> 581: && ((BigInteger) number).bitLength() <
>> 64)) {
>> 582: return format(((Number) number).longValue(), toAppendTo,
>> 583: fieldPosition);
>
> This is a prime example for switch pattern match, but probably for another
> day.
Filed: https://bugs.openjdk.org/browse/JDK-8336847
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1684986049
