On Wed, 24 Jul 2024 21:59:52 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into merge_store_bench >> - move to vm.compiler >> - Merge remote-tracking branch 'upstream/master' into merge_store_bench >> - Merge remote-tracking branch 'upstream/master' into merge_store_bench >> - bug fix for `putChars4C` >> - bug fix for `putChars4C` and `putChars4S` >> - use VarHandler CHAR_L & CHAR_B >> - copyright >> - bug fix for putIntBU >> - add cases for `getChar` & `putChar` >> - ... and 6 more: https://git.openjdk.org/jdk/compare/19a79110...d00654ff > > Here are the performance numbers running on the new MacBook M1 Pro, > > * Test scenarios with significant performance improvements > > Benchmark Mode Cnt Score-Old Score-New Units > MergeStoreBench.putChars4BU avgt 15 10266.123 3830.198 * ns/op > MergeStoreBench.putChars4LU avgt 15 10266.238 3827.784 * ns/op > MergeStoreBench.setIntLU avgt 15 5103.562 2573.624 * ns/op > MergeStoreBench.setLongLU avgt 15 10304.012 2921.575 * ns/op > MergeStoreBench.setLongRLU avgt 15 10263.975 3241.057 * ns/op > > > * > > Benchmark Mode Cnt Score-Old Score-New Units > MergeStoreBench.getCharB avgt 15 5341.787 5340.200 ns/op > MergeStoreBench.getCharBU avgt 15 5477.363 5482.163 ns/op > MergeStoreBench.getCharBV avgt 15 5163.099 5074.165 ns/op > MergeStoreBench.getCharC avgt 15 5068.708 5051.763 ns/op > MergeStoreBench.getCharL avgt 15 5379.821 5374.464 ns/op > MergeStoreBench.getCharLU avgt 15 5477.268 5487.532 ns/op > MergeStoreBench.getCharLV avgt 15 5079.045 5071.263 ns/op > MergeStoreBench.getIntB avgt 15 6276.548 6277.984 ns/op > MergeStoreBench.getIntBU avgt 15 5229.813 5232.984 ns/op > MergeStoreBench.getIntBV avgt 15 1207.868 1206.264 ns/op > MergeStoreBench.getIntL avgt 15 6182.150 6172.779 ns/op > MergeStoreBench.getIntLU avgt 15 5164.260 5157.317 ns/op > MergeStoreBench.getIntLV avgt 15 2555.443 2558.110 ns/op > MergeStoreBench.getIntRB avgt 15 6879.188 6889.916 ns/op > MergeStoreBench.getIntRBU avgt 15 5771.857 5769.950 ns/op > MergeStoreBench.getIntRL avgt 15 6625.754 6625.605 ns/op > MergeStoreBench.getIntRLU avgt 15 5746.554 5746.742 ns/op > MergeStoreBench.getIntRU avgt 15 2547.449 2544.586 ns/op > MergeStoreBench.getIntU avgt 15 2543.552 2541.119 ns/op > MergeStoreBench.getLongB avgt 15 12099.002 12098.129 ns/op > MergeStoreBench.getLongBU avgt 15 9771.893 9760.621 ns/op > MergeStoreBench.getLongBV avgt 15 2593.835 2593.635 ns/op > MergeStoreBench.getLongL avgt 15 12045.235 12031.065 ns/op > MergeStoreBench.getLongLU avgt 15 9659.585 9653.938 ns/op > MergeStoreBench.getLongLV avgt 15 2561.089 2557.521 ns/op > MergeStoreBench.getLongRB avgt 15 12095.060 12092.061... @wenshao generally we like to have at least 2 reviews before integration ;) ------------- PR Comment: https://git.openjdk.org/jdk/pull/19734#issuecomment-2249791741
