On Fri, 26 Jul 2024 06:29:05 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails >> on rpm build mock environment. The `df -h` command return fail `df: cannot >> read table of mounted file systems: No such file or directory` on the rpm >> build mock environment also. I think it's a environmental issue, and the >> environmental issue should not cause the test fails, it should skip the test. >> >> The rpmbuild mock enviroment is like a sandbox, which created by `chroot` >> shell command, in the rpmbuild mock enviroment, `df -h` report `cannot read >> table of mounted file systems`, and java Files.getFileStore also throw >> `IOException`. We want to build and test the jdk in this `sandbox`, and the >> default jtreg work directory is `JTWork` in current directory, so this >> testcase will report fails. >> >> Only change the testcase, the change has been verified locally, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add the exception's toString() into SkipException The latest change looks OK to me. Please wait for Alan to decide if this is OK to integrate. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19905#pullrequestreview-2201036393
