On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> The current LocalDateTime.toString implementation concatenates the toString >> results of date and time, which can be passed to StringBuilder to reduce >> additional object allocation and improve performance. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > Update src/java.base/share/classes/java/time/LocalTime.java > > Co-authored-by: Chen Liang <li...@openjdk.org> It's my fault to not wait for sufficient reviews and downplay the importance of the comments. New comments can reveal more subtle mistakes in understanding of code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20321#issuecomment-2252820315
