On Tue, 27 Aug 2024 22:23:44 GMT, Srinivas Vamsi Parasa <d...@openjdk.org> wrote:
>> I agree, this is all rather obscure. Ideally the same names that are used in >> wherever this comes from. >> >> Where does the algorithm come from? What are its accuracy guarantees? >> >> In addition, given the rarity of hyperbolic tangents in Java applications, >> do we need this? > > @theRealAph, this implementation is based on Intel libm math library and > meets the accuracy requirements. The algorithm is provided in the comments. Do you have a copy of this information? Should it be in the commit? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20657#discussion_r1734776732
