On Thu, 29 Aug 2024 20:14:57 GMT, Chen Liang <li...@openjdk.org> wrote:
> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and > confusing. Users should almost always use `loadConstant(ConstantDesc)` for > optimized instructions, or use specific factories `iconst_0` etc. or `bipush` > with arguments or `LoadConstantInstruction.of` if they want to specify the > exact type of LDC opcode. This pull request has now been integrated. Changeset: ad40a122 Author: Chen Liang <li...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/ad40a122d632d65052b71125c0dfd58c54e3a521 Stats: 207 lines in 10 files changed: 6 ins; 157 del; 44 mod 8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc) Reviewed-by: asotona ------------- PR: https://git.openjdk.org/jdk/pull/20779