On Mon, 16 Sep 2024 07:27:06 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> src/hotspot/share/opto/vectornode.cpp line 2148: >> >>> 2146: >>> 2147: BoolTest::mask pred = BoolTest::lt; >>> 2148: ConINode* pred_node = >>> (ConINode*)phase->makecon(TypeInt::make(pred)); >> >> Would `as_ConI()` be a better alternative to the `(ConINode*)` cast? > > Please at least add a comment why you are not following my suggestion. I feel > like the work I put in to review is not being respected when comments are > just silently resolved without any action or comment. I really do think that `as_ConI()` would be the right thing here. In product it is just a cast, and in debug at least we have an assert. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1760657072
