On Fri, 13 Sep 2024 17:38:56 GMT, Shaojin Wen <s...@openjdk.org> wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - rename JDKUTF to ModifiedUtf
> - suggestion from @liach
Looks good besides these 2 nitpicks. I will ask an io engineer to look at this
too.
src/java.base/share/classes/jdk/internal/util/ModifiedUtf.java line 1:
> 1: /*
Can add a private constructor
src/java.base/share/classes/jdk/internal/util/ModifiedUtf.java line 59:
> 57: */
> 58: @ForceInline
> 59: public static int utflen(String str, int countNonZeroAscii) {
maybe `utfLen` as utf and len are 2 words?
-------------
PR Review: https://git.openjdk.org/jdk/pull/20886#pullrequestreview-2306617461
PR Review Comment: https://git.openjdk.org/jdk/pull/20886#discussion_r1761128734
PR Review Comment: https://git.openjdk.org/jdk/pull/20886#discussion_r1761132583
