On Thu, 19 Sep 2024 21:09:43 GMT, Mat Carter <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: do not check for -XX:AOTMode=create in JLI java.c
>
> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 40:
>
>> 38: strcmp(value, "create") != 0 &&
>> 39: strcmp(value, "auto") != 0 &&
>> 40: strcmp(value, "on")) {
>
> This should be strcmp(value, "on") != 0 ??
Okay both ways are valid, you could also remove the other "!= 0", the mixing
was confusing
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1767653154
