On Tue, 1 Oct 2024 16:12:57 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into ziperror-deprecation >> - Simplify the deprecation note by focusing on behavior in the current >> release >> - Extend the deprecation note to mention that the error became obsolete in >> JDK 9 and to mention that code may be updated to catch the super class >> InternalError >> - Update copyright year >> - Deprecate java.util.zip.ZipError for removal > > src/java.base/share/classes/java/util/zip/ZipError.java line 31: > >> 29: * Signals that an unrecoverable error has occurred. >> 30: * >> 31: * @deprecated ZipError is no longer used and is obsolete. > > I agree ZipError should be deprecated. Can the JBS issue and PR title be > updated as they still have "for removal". Isn't this deprecation intended for removal? Or do you mean this `@deprecated` tag should note that this class will be removed in a future release? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20642#discussion_r1783157380
