On Tue, 10 Sep 2024 05:36:17 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 20 commits: >> >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - cleanup testExtractNoDestDirWithPFlag() test >> - merge latest from master branch >> - merge latest from master branch >> - convert the new test to junit >> - merge latest from master branch >> - ... and 10 more: https://git.openjdk.org/jdk/compare/56387a09...129375da > > src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java line 268: > >> 266: CREATE_UPDATE_INDEX("create.update.index"), >> 267: OTHER("other"), >> 268: EXTRACT("extract"); > > Is the order number important in this non-public `enum`? If not, I would > expect `OTHER` to remain the last/highest entry. Hello Christian, I've now updated the PR to keep `OTHER` as the last enum value. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/2752#discussion_r1789496446
