On Tue, 1 Oct 2024 18:16:56 GMT, Justin Lu <j...@openjdk.org> wrote:

>> Johny Jose has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review changes
>
> src/java.base/share/classes/java/time/ZoneId.java line 191:
> 
>> 189:      * This map contains a mapping of the IDs that is in line with TZDB 
>> 2024b and
>> 190:      * later, where 'EST', 'MST' and 'HST' map to IDs which do not 
>> include daylight
>> 191:      * savings since 1970.
> 
> Hi Johny, the future flexibility clause seems to be missing in the spec 
> update of ZoneId.

Thanks for the changes in 
https://github.com/openjdk/jdk/pull/21265/commits/c3238444b63cb87c61f2503cbb1b5b7452181533.

Can we also add the following to the ZoneId specification,

Suggestion:

     * savings since 1970. This mapping may change in update releases in 
support of new versions of TZDB.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21265#discussion_r1792184364

Reply via email to