On Mon, 7 Oct 2024 14:53:48 GMT, SendaoYan <s...@openjdk.org> wrote: >> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp >> mode. > > Thanks for the review.
Hello @sendaoYan, I noticed this PR today. For tests that we want to exclude from Xcomp testing, the convention has been to use a `@requires vm.compMode != "Xcomp"` in the test definition of the test case instead of problem listing it. Problemlisting is prefered if there is any genuine issue that needs to be addressed at a later date. In this current case, based on what Jorn noted in this PR, I think the right thing to do would be to use the `@requires` in the test case and remove this test from the problem listing. I think you can use JDK-8341584 to remove the test from the problem list and use `@requires` instead. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21375#issuecomment-2411655223
