On Sun, 13 Oct 2024 03:52:01 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which improves the safety of equality checking for >> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for >> NPE in the equality method. This PR now updates the setters to throw NPE. >> >> In addition to the NPEs, there is also a behavioral change that >> `setInternationalCurrencySymbol` no longer sets currency to null if the >> `currencyCode` is invalid. Instead, it simply does not update `currency`. >> This must be done, because we do not want to allow nullable instance >> variables post `initalizeCurrency`. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > reflect further review Marked as reviewed by naoto (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21315#pullrequestreview-2367398290
