On Wed, 16 Oct 2024 17:40:36 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> Please review the changes for > [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a > follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which > addresses that > > - ZipEntry(String) > - ZipEntry::setComment > - ZipEntry::setExtra > > currently validate that the max possiible field size is 0xFFFF(65535) instead > of 0xFFD1(65489) not taking into account the size of the CEN header which is > 46 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12 > > The CSR has been approved. > Mach5 tiers1-3 run clean as do the relevant JCK tests test/jdk/java/util/zip/ZipOutputStream/ZipOutputStreamMaxCenHdrTest.java line 171: > 169: try (ZipOutputStream zos = new ZipOutputStream( > 170: new > BufferedOutputStream(Files.newOutputStream(ZIP_FILE)))) { > 171: if (expectZipException) { Hello Lance, with this change, it looks like this now misses calling the `zos.putNextEntry(zipEntry)` when `expectZipException` is `false`. Is that an oversight? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1804206491
