On Mon, 21 Oct 2024 20:31:59 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> src/hotspot/share/memory/iterator.inline.hpp line 57:
>>
>>> 55: ClaimMetadataVisitingOopIterateClosure::do_cld(cld);
>>> 56: } else {
>>> 57: assert_is_pending_aot_linked_class(k);
>>
>> Would there be a drawback to just adding
>> `assert(AOTLinkedClassBulkLoader::is_pending_aot_linked_class(k),
>> "sanity");` here and skip the changes the both .hpp and .cpp files?
>
> I changed the code to `assert(is_pending_aot_linked_class(k), "sanity")`.
> Since iterator.hpp is widely used, I avoid including
> aotLinkedClassBulkLoader.hpp in this header, and route the call through
> iterator.cpp.
My proposal was to use it in this file (iterator.inline.hpp) and not
iterator.hpp. I see no need to route this through the .cpp file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1810071099
