On Sun, 20 Oct 2024 06:50:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which does a tiny cleanup in the >> macosx specific code in `java_props_macosx.c`? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8342647 the >> `setOSNameAndVersion` function used to dynamically call >> `NSProcessInfo.operatingSystemVersion` because that property wasn't >> (statically) available until macosx 10.10 version. Since that version this >> property has been available even in the latest macosx versions >> https://developer.apple.com/documentation/foundation/nsprocessinfo/1410906-operatingsystemversion, >> so it's now possible to statically reference it in the code. >> >> The change in this PR replaces the use of `NSInvocation` with the static >> reference to this property. No new tests have been added. Existing tier1, >> tier2 and tier3 tests with this change have all passed. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > minor code comment update It's great that we can finally call the function statically. =D ------------- Marked as reviewed by bchristi (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21595#pullrequestreview-2406674597
