On Tue, 29 Oct 2024 22:58:31 GMT, Dean Long <dl...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 316:
>
>> 314: pc = ContinuationHelper::return_address_at(
>> 315: sp - frame::sender_sp_ret_address_offset());
>> 316: }
>
> You could do this with an overload instead:
>
> static void set_anchor(JavaThread* thread, intptr_t* sp, address pc) {
> assert(pc != nullptr, "");
> [...]
> }
> static void set_anchor(JavaThread* thread, intptr_t* sp) {
> address pc = ContinuationHelper::return_address_at(
> sp - frame::sender_sp_ret_address_offset());
> set_anchor(thread, sp, pc);
> }
>
> but the compiler probably optmizes the above check just fine.
Added an overload method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1828187178
