On Wed, 6 Nov 2024 00:56:49 GMT, David Holmes <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix: jvm_md.h was included, but not jvm.h...
>
> src/hotspot/os/windows/os_windows.cpp line 510:
>
>> 508: // Thread start routine for all newly created threads.
>> 509: // Called with the associated Thread* as the argument.
>> 510: static unsigned thread_native_entry(void* t) {
>
> Whoa! Hold on there. The `_stdcall` is required here and nothing to do with
> 32-bit. We use `begindthreadex` to start threads and the entry function is
> required to be `_stdcall`.
> https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/beginthread-beginthreadex?view=msvc-170
Not sure why this comment was marked as "Resolved". I have the same question
here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1832573434
