On Wed, 13 Nov 2024 15:31:59 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Javac is not issuing a mandated unchecked cast warning for code like: >> >> >> import java.lang.invoke.VarHandle; >> >> class VarHandleCast<V> { >> VarHandle vh; >> V method(Object obj) { >> return (V)vh.getAndSet(this, obj); >> } >> } >> >> >> according to the spec the return type inferred for this method polymorphic >> method should be Object see: >> >> - If the compile-time declaration for the method invocation is a signature >> polymorphic method, then: >> ... >> – The compile-time result is determined as follows: >> Otherwise, if the method invocation expression is the operand of a >> cast >> expression (§15.16), the compile-time result is the erasure of the type >> of the >> cast expression (§4.6). >> >> javac is not doing the type erasure mandated by the spec which is what this >> PR is fixing >> >> TIA >> >> Note: I had to add some annotations to suppress warnings in java.base that >> were not being issued before due to the javac bug > > Vicente Romero has updated the pull request incrementally with one additional > commit since the last revision: > > address review comments Marked as reviewed by mcimadamore (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21914#pullrequestreview-2433605574