On Tue, 19 Nov 2024 00:58:18 GMT, Brent Christian <[email protected]> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop --add-exports from the test
>
> test/jdk/jdk/internal/ref/Cleaner/CleanableListTest.java line 46:
>
>> 44: public class CleanableListTest {
>> 45:
>> 46: static final int SINGLE_NODE_CAPACITY =
>> CleanableListTestHelper.NODE_CAPACITY - 1;
>
> If `CleanableListTestHelper` uses a list without the `CleanerCleanable`,
> shouldn't we be able to test the full `NODE_CAPACITY` ?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1847851778
