On Fri, 29 Nov 2024 18:53:52 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I please get a review for this PR that add tests to verify the value of >> `@since` tags to the Tools area modules. The test is described in this >> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). >> This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442. >> >> The benefit from this is helping API authors and reviewer validate the >> accuracy of `@since` in their source code (and subsequently, in the >> generated documentation). And lessen the burden on Reviewers. >> >> The test has been added for `java.base` and a few other modules and has >> helped catch some bugs before they make it to the JDK. >> >> Notes: >> - I have also added an `@since` tag that was missing. >> - You will notice there is no test for the `jdk.jfr` module, it will be >> added in a future PR because it requires special handling. (JFR used to be a >> commercial feature and this requires special handling to be added for it in >> the test) >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > add a missing \@since tag to RecordingStream.onMetadata Reverting the change to `RecordingStream`, as [JDK-8345339](https://bugs.openjdk.org/browse/JDK-8345339) will filed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21982#issuecomment-2513176418
