On Mon, 13 Jan 2025 11:29:06 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> Please review this change request enabling native access in source launch >> mode when using a modular setup. >> >> The change comes in two parts: >> 1. Prevent warnings of unknown modules being emitted from module bootstrap >> for user module not being present in the boot layer: `java.c` and >> `ModuleBootstrap.java` >> 2. Enable native access in source module(s) and also user modules on the >> module path as requested by `--enable-native-access` via the >> `ModuleLayer.Controller` API - and emit warning for unknown modules: >> `MemoryContext.java` >> >> _Testing of tier1..3 is in progress..._ > > Christian Stein has updated the pull request incrementally with three > additional commits since the last revision: > > - Update src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java > - Update src/java.base/share/native/libjli/java.c > > [skip ci] > - Update src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java > > [skip ci] Good, I don't have any other comments on this. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22930#pullrequestreview-2547469239
