On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole <ecasp...@openjdk.org> wrote:
> The normal SQE process runs all the repo JMH with -ea to get the last bit of > extra testing. This DremFrem JMH contained some asserts that would always > fire on the correct answer, disturbing this normal SQE process. I removed a > lot more asserts from this JMH which seemed to make it more of a SQE test > than a benchmark. We would prefer to keep benchmarks as benchmarks as much as > possible and not creep into tests. These benchmarks are malformed indeed; the blackhole is never used. @ericcaspole Do you mean hotspot-compiler for the label instead of javac? Also might need to add an 2025 copyright header for this file. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23917#pullrequestreview-2661738797 PR Comment: https://git.openjdk.org/jdk/pull/23917#issuecomment-2701485115 PR Comment: https://git.openjdk.org/jdk/pull/23917#issuecomment-2701489585
