On Fri, 14 Mar 2025 13:55:26 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line
>> 226:
>>
>>> 224: if (Files.exists(strippedPath)) {
>>> 225: path = strippedPath;
>>> 226: }
>>
>> This is super weird to put here. I could imagine introducing a Windows
>> specific plugin or option for jlink to help with this setup but I don't
>> think we should rush into a change to JRTArchive to workaround this.
>
> A jlink plugin sounds like a reasonable approach to me.
I don't see how a jlink plugin could help with this. The plugin-pipeline runs
after the archive resources have been processed (i.e. the latter feed into the
former). If archive processing fails you won't get to plugin processing.
With that said, I agree with Alan, this isn't a good place to deal with this.
We'd have two special cases - 1) in the build system that copies over full pdb
files 2) here in jlink to deal with the result of (1).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24057#discussion_r1995732524
