On Mon, 24 Mar 2025 02:50:04 GMT, Chen Liang <[email protected]> wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied changes requested by Chen
>
> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1911:
>
>> 1909: * @implNote This method allows for superior performance over the
>> default
>> 1910: * implementation in {@code CharSequence}. It performs a direct
>> 1911: * buffer-to-array copy of the complete specified region.
>
> I think the API and implementation notes are redundant.
Do you think? The `implNote` here explains that it *actually* provides superior
performance, while that API notes do say nothing about *actual* implementation.
Anyways, I have no strong feelings. Shall I remomve it? 🤔
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2010005500
