On Sat, 29 Mar 2025 23:53:36 GMT, Chen Liang <[email protected]> wrote:
>> Markus KARG has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Applied changes requested by Alan: This sentence doesn't make sense, did
>> something get deleted?
>> - Applied changes requested by Alan: Copies chars from this sequence into
>> the given destination array
>> - Replaced JavaDocs of CharBuffer, as suggested by Alan
>
> src/java.base/share/classes/java/lang/CharSequence.java line 335:
>
>> 333: * @implSpec
>> 334: * The default implementation invokes {@link #charAt(int index)} in
>> a loop
>> 335: * iterating {@code index} from {@code srcBegin} to {@code srcEnd-1}
>
> We might need to specify the IOOBE behavior - when an IOOBE is thrown, some
> characters may be already transferred (this is important for concurrent char
> sequences)
Good idea. Added clarification in
https://github.com/openjdk/jdk/pull/21730/commits/d2ccf42cec148a86b17753d160df211925f75858.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2020144741
