On Wed, 2 Apr 2025 18:46:06 GMT, Viktor Klang <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableValueFactoriesTest.java line 36:
>
>> 34: import static org.junit.jupiter.api.Assertions.*;
>> 35:
>> 36: final class StableValueFactoriesTest {
>
> Just confirming—this is all that needs testing here?
I've removed most methods from the factories and referenced implementations
directly. So, only one method remains here. However, it might be the case that
I need to resurrect some of the methods here as we progress in using stable
values internally in the JDK (as StableValue is a preview feature but the
underlying implementations are not).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2026732065
