On Tue, 8 Apr 2025 09:21:50 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8352642: Also pass zipinfo-time to the alternative newFileSystem call > > src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java > line 581: > >> 579: // Less common case is possible if the file manager was >> not initialized in JavacTask, >> 580: // or if non "*.jar" files are on the classpath. At the >> time of writing, both `javac -cp a.zip` >> 581: // and `javac -cp x.JAR` file would hit this branch >> which may warrant investigation. > > Hello Jason, do we need that second sentence to be added as a code comment? I > feel it creates confusion on what's expected to be done. Perhaps just add > that first sentence and remove the second? Could you also update the copyright year on this file from 2024 to 2025? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24176#discussion_r2032774982
