On Tue, 15 Apr 2025 21:54:56 GMT, Calvin Cheung <[email protected]> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> since the last revision:
>>
>> - Merge branch 'master' into
>> 8352001-exclude-injected-classes-from-builtin-loaders
>> - 8352001: AOT cache should not contain classes injected into built-in
>> class loaders
>
> src/hotspot/share/classfile/classLoaderExt.cpp line 105:
>
>> 103:
>> 104: if (CDSConfig::is_dumping_preimage_static_archive() ||
>> CDSConfig::is_dumping_dynamic_archive()) {
>> 105:
>> AOTClassLocationConfig::dumptime()->check_invalid_classpath_index(classpath_index,
>> result);
>
> In case the `classpath_index` is invalid, I don't think we should call
> `AOTClassLocationConfig::dumptime_update_max_used_index()`. Maybe the
> `check_invalid_classpath_index()` function should return a bool and have
> `ClassLoaderExt::record_result()` update the classpath index and max used
> index.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24046#discussion_r2045794966
