On Wed, 16 Apr 2025 16:08:21 GMT, Jaikiran Pai <[email protected]> wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied changes requested by Chen: 'We might need to specify the IOOBE
>> behavior - when an IOOBE is thrown, some characters may be already
>> transferred (this is important for concurrent char sequences)'
>
> src/java.base/share/classes/java/lang/CharSequence.java line 342:
>
>> 340: * @since 25
>> 341: */
>> 342: public default void getChars(int srcBegin, int srcEnd, char[] dst,
>> int dstBegin) {
>
> Hello Markus, given these new methods on `CharSequence` and the `CharBuffer`,
> we should add a jtreg test to verify that the default implementation of these
> methods do work as specified.
>
> Edit: I now see Chen too had a similar comment about adding a regression test.
This is already discussed in a separate thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2047265794
