On Thu, 17 Apr 2025 10:47:03 GMT, Viktor Klang <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address comments on original vs underlying
>
> src/java.base/share/classes/java/lang/StableValue.java line 422:
>
>> 420: * As objects can be set via stable values but never removed,
>> this can be a source
>> 421: * of unintended memory leaks. A stable value's content is
>> 422: * {@linkplain java.lang.ref##reachability strongly
>> reachable}. Clients are
>
> I wonder if "Clients" is the best word here. Perhaps "Developers"?
I think you can drop the 'clients are advised that' prefix here. (I think
usually it's 'X are advised to Y', and you would use 'be advised that X' as a
general statement.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2050610207
