On Wed, 23 Apr 2025 18:06:27 GMT, Johannes Graham <[email protected]> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Improve test per reviewer comments
>
> src/java.base/share/classes/java/io/Reader.java line 212:
>
>> 210:
>> 211: public String readAllChars() throws IOException {
>> 212: return cs.toString();
>
> Should this be returning a substring of `cs` starting at `next`? Also likely
> needs a `ensureOpen`
You are correct on both counts. That was pretty lame on my part. Will update.
Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2056729165
