On Wed, 23 Apr 2025 13:39:40 GMT, ExE Boss <d...@openjdk.org> wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/new-generic-info >> - Improve BytecodeDescriptor error message >> - Years, test facelift >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/new-generic-info >> - 8333377: Migrate Generic Signature parsing to ClassFile API > > src/java.base/share/classes/sun/reflect/generics/info/ClassGenericInfo.java > line 1: > >> 1: /* > > Given that this basically rewrites most of `sun.reflect.generics.*`, I feel > like it might be better to just move these new files to > `jdk.internal.reflect.generics.*`.
We should, in fact, remove as much legacy `sun` packages as possible - for the particular package name choice, I think `jdk.internal.reflect.type` might be better, as we are really reflecting on language types. But I think that effort will get its own ticket. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19281#discussion_r2056908805
