On Tue, 29 Apr 2025 07:54:23 GMT, Andrew Haley <a...@openjdk.org> wrote:

>> Propose to finalize scoped values.
>> The only functional change is that the orElse() method no longer accepts a 
>> null argument.
>
> Andrew Haley has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Since when?

test/jdk/java/lang/ScopedValue/ScopedValueAPI.java line 424:

> 422:         assertThrows(NullPointerException.class, () -> 
> carrier.run(null));
> 423:         assertThrows(NullPointerException.class, () -> 
> carrier.call(null));
> 424:         assertThrows(NullPointerException.class, () -> carrier.run(() -> 
> name.orElse(null)));

Thanks for brining in the update to ScopedValueAPI test. The `@enablePreview` 
can be removed from the test description of this test, and the others in this 
directory that don't use STS.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24923#discussion_r2065949496

Reply via email to