ons. 30. apr. 2025 kl. 14:13 skrev Jaikiran Pai <j...@openjdk.org>: > > Hello Eirik, > > > Before this change, two ZipFile instances opened using different > (non-UTF-8) charsets would have equal keys, and thus be backed by the same > Source and ZipCoder instance, whichever ZipFile constructed first would > "win". > > This seems like a separate bug, independent of the concurrency concerns > described JDK-8347712. > > For the benefit of future maintainers, I think this independent bug > should be described in a separate JBS issue. > > That's right - when fixing 8347712 I saw this issue with `Key` class and > addressed it in this PR. You have a good point that having a JBS issue > specifically for this will be useful. I have now created > https://bugs.openjdk.org/browse/JDK-8355975 and linked that issue in this > current PR. What helped was your test case example that uses `ISO-8859-15` > and `ISO-8859-1` charsets to trigger this issue. I wasn't aware of that > difference between `ISO-8859-15` and `ISO-8859-1` charsets. Thank you, I've > now added that test in this PR.
Thanks Jaikiran for addressing this bad other comments. I’m limited to the mobile UI of GitHub right now, but everything looks good. Thanks for adding the test 👍 Eirik. >
