On Thu, 1 May 2025 18:43:57 GMT, Chen Liang <[email protected]> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating copyright year.
>
> src/java.base/share/classes/java/lang/IO.java line 157:
>
>> 155: * <p>
>> 156: * Writes a prompt as if by calling {@code print}, and then reads a
>> single
>> 157: * line of text as if by calling {@link readln readln()}.
>
> Is this intended to render like `readln` or `readln()`? I always recommend
> prefixing member references with `#` like `#readln()`.
I added `#` prefixes. I had intended `readln()` to indicate that this referred
to the no-arg overload of `readln()` but I think that's too subtle so I removed
the parens. But one has to look at the link to determine that it refers to the
no-arg readln and not the one-arg readln (which is this method). I also changed
the `print` to a link as well.
> src/java.base/share/classes/java/lang/IO.java line 179:
>
>> 177: * the reader() method.
>> 178: */
>> 179: static BufferedReader br;
>
> The comments should indicate all access should be through `reader`, and this
> field is best made private to indicate direct field access is **not thread
> safe**.
Added a comment. Making it `private` doesn't really help, but I made it private
anyway.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2070971289
PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2070970447
