On Fri, 2 May 2025 16:43:02 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> test/hotspot/jtreg/testlibrary/asm/org/objectweb/asm/ClassReader.java line
>> 229:
>>
>>> 227: // Check the class' major_version. This field is after the
>>> magic and minor_version fields, which
>>> 228: // use 4 and 2 bytes respectively.
>>> 229: if (checkClassVersion && readShort(classFileOffset + 6) >
>>> Opcodes.V26) {
>>
>> Please do not change ASM - if a test uses ASM to generate or parse later
>> class files, they must migrate to the ClassFile API. Open a JBS issue and
>> identify the hotspot tests failing without this change.
>
> There are various HotSpot tests that use ASM and they all fail under JDK 26
> without this change.
Hopefully new tests will use the ClassFile API and that over time that some of
the existing tests that use ASM can be migrated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25008#discussion_r2071884496
