On Thu, 15 May 2025 00:16:32 GMT, Calvin Cheung <cche...@openjdk.org> wrote:

>> This fix adds the `--add-reads` support for CDS and AOTClassLinking.
>> Before the fix, if the `--add-reads` is specified during CDS archive 
>> dumping, the user will see the following log if `-Xlog:cds=info` is enabled:
>> `[0.000s][info][cds] optimized module handling: disabled due to incompatible 
>> property: jdk.module.addreads=com.norequires=org.astro`
>> During runtime, the archived full module graph will be disabled:
>> `[0.021s][info][cds       ] full module graph: disabled`
>> 
>> With the fix, the optimized module handling won't be disabled during dump 
>> time and the full module graph will be enabled during runtime provided the 
>> same --add-reads option is specified during dump time and runtime.
>> 
>> Testing: tiers 1 - 4.
>
> Calvin Cheung has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains four additional 
> commits since the last revision:
> 
>  - @iklam comment
>  - Merge branch 'master' into 8354083-add-reads
>  - fix trailing whitespace
>  - 8354083: Support --add-reads with -XX:+AOTClassLinking

LGTM

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25109#pullrequestreview-2842162246

Reply via email to