On Tue, 13 May 2025 14:46:00 GMT, Ivan Bereziuk <d...@openjdk.org> wrote:
>> PAWAN CHAWDHARY has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor container runtime version code
>
> The change looks good. There might be some issues with container engine
> version parsing.
>
> I wrote 2 comments. but cold not post them. They are in "pending" state.
> Not sure why. Should the comments be first reviewed by {Committers|Reviewers}?
@Domest0s I have tested against both docker and podman version and it was able
to parse
for eg `docker version 20.10.0` and `podman version 4.9.4-rhel`
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24948#issuecomment-2883250455
