On Mon, 19 May 2025 06:59:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>>> I read this sentence a couple of times [...] >> >> Please see >> [a86610d](https://github.com/openjdk/jdk/pull/24728/commits/a86610d06169445a5c4b81a0c60527130a45e045). >> >>> I suspect that sentence was motivated from similar existing text in >>> `Files.readString(...)` and there too I find it confusing. >> >> If you think it worthwhile, please file an issue to improve that verbiage as >> well. > > Thank you Brian, the updated text for this section looks good to me. Once > this PR gets integrated, I'll go through the Files.readXXX methods and file > an issue to have that text simplified too. I see this has been changed to "then some characters, but not all" but it doesn't flow very well. The original sentence, which was copied/modified from InputStream.readAllBytes, is much cleaner and I think I would prefer to go back to that. Maybe Jai's issue could be address by dropping the first comma from the sentence? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2095001660
