On Mon, 9 Jun 2025 15:52:24 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> After we converted the source base to be fully UTF-8, we do not need to use 
>> unicode sequences (like \u0123) in string literals. Sometimes, that might 
>> still make sense, as for control characters, non-breaking space, etc. But 
>> for strings that is supposed to be a coherent text in a language that needs 
>> non-ASCII parts of Unicode, this is not so. Instead, having the sequences 
>> makes the text just harder to read and edit. We have already removed several 
>> such sequences before, but some remains.
>
> Magnus Ihse Bursie has updated the pull request incrementally with three 
> additional commits since the last revision:
> 
>  - Fix comment indentation
>    
>    Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>  - Concatenate string literals
>    
>    Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>  - Concatenate string literals
>    
>    Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25229#pullrequestreview-2910543905

Reply via email to