On Tue, 10 Jun 2025 16:37:26 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> 
wrote:

>> Per Minborg has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use a fixed threashold for fill
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java 
> line 55:
> 
>> 53: 
>> 54:     // All the threshold values below MUST be a power of two and greater 
>> or equal to 2^3.
>> 55:     private static final int NATIVE_THRESHOLD_FILL = 32;
> 
> Is there any reason you removed this property? While I understand that 
> performance can regress for bigger sizes, taking away the property seems 
> harsh/asymmetric?

So, eventually, I'd like to move away from using these properties once the 
consuming method is fairly stable across both platforms and workloads. I am 
hoping to do the same for the remaining operations once they are revisited.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25383#discussion_r2138381943

Reply via email to