On Mon, 9 Jun 2025 23:44:20 GMT, Justin Lu <j...@openjdk.org> wrote: >> Johannes Graham has updated the pull request incrementally with one >> additional commit since the last revision: >> >> catch ArithmeticException > > src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1848: > >> 1846: buf[i] = (byte) digits[i]; >> 1847: } >> 1848: return new ASCIIToBinaryBuffer(false, decExp, buf, length); > > Since `negSign` is always false, adding a _positive_ somewhere to the method > name might be helpful/explicit. Although you could argue that the array > parameter itself is telling enough, but one could misinterpret the char array > as including a sign character.
Thanks, I think "signless" is better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25644#discussion_r2141278327
